Chaining click events (double/triple click etc) #5369
Conversation
…clicks itself [no ci]
…s purpose and behavior
…m typing_extensions
… on_mount method to LazyApp for better lifecycle management in tests
src/textual/app.py
Outdated
| @@ -4325,10 +4355,12 @@ def suspend(self) -> Iterator[None]: | |||
| # app, and we don't want to have the driver auto-restart | |||
| # application mode when the application comes back to the | |||
| # foreground, in this context. | |||
| # fmt: off | |||
There was a problem hiding this comment.
Ruff formats this code into parentheses, and you can't use parentheses in context managers on 3.8.
There was a problem hiding this comment.
Fixed by adding:
[tool.ruff]
target-version = "py38"To pyproject.toml.
| @@ -556,8 +557,88 @@ class Click(MouseEvent, bubble=True): | |||
|
|
|||
| - [X] Bubbles | |||
| - [ ] Verbose | |||
|
|
|||
| Args: | |||
There was a problem hiding this comment.
I've copied the docstring format from other classes in this module, assuming inheritance etc. rather than copy pasting a huge docstring several times.
| You can simulate double and triple clicks by setting the `times` parameter. | ||
|
|
||
| ```python | ||
| await pilot.click(Button, times=2) # Double click |
There was a problem hiding this comment.
We are calling times here and chain on the event?
I see why. It reads like "click button 2 times". But it feels inconsistent.
There was a problem hiding this comment.
I agree it's a bit inconsistent but I think of the event being a lower level technical thing and as you said pilot interacting from the user POV.
There was a problem hiding this comment.
How about a pilot.double_click and pilot.triple_click (in addition to the times parameter?
chainattribute onClickevents.pilot.clickwith atimesargument, allowing double/triple/etc clicks.This PR doesn't implement any features which make use of double/triple clicks.
Please review the following checklist.